Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs are rendered with wrong YAML indentation on website #11572

Closed
mbrancato opened this issue May 10, 2021 · 5 comments
Closed

Docs are rendered with wrong YAML indentation on website #11572

mbrancato opened this issue May 10, 2021 · 5 comments
Labels

Comments

@mbrancato
Copy link
Contributor

Describe the bug
The website has not been updated to the latest version of the docs, but starting with this line in the Vault Kubernetes documentation, the fields are outdented and should be nested under injector in the current website docs version, and agentDefaults in the next release:
https://github.com/hashicorp/vault/blame/e27b43c4829223555484b2fb7f0049b3ec2881fc/website/content/docs/platform/k8s/helm/configuration.mdx#L128

Here is the beginning of the injector block:
image

And here is where the injector.extraLabels begins:
image

Note that the injector.objectSelector is correctly indented.

I've tested in Chrome and Safari.

To Reproduce
Steps to reproduce the behavior:

  1. View docs page: https://www.vaultproject.io/docs/platform/k8s/helm/configuration#objectselector

Expected behavior
The indentation should match the documentation.

@SohamJ
Copy link

SohamJ commented May 12, 2021

This also seems to apply to all configs that follow extraLabels like certs, failurePolicy, annotations, etc based on the injector-deployment template

@jasonodonnell
Copy link
Contributor

Thanks, we'll fix this today!

@jasonodonnell
Copy link
Contributor

We found the root cause of the issues, this should be fixed now.

@aphorise
Copy link
Contributor

Hey @mbrancato is this still an issue or did @jasonodonnell fix it already?

@kitography
Copy link
Contributor

This looks fixed to me (looking at the documentation now), but feel free to reopen if I've missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants