Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support exec in server liveness probe #971

Merged
merged 8 commits into from
Nov 9, 2023
Merged

support exec in server liveness probe #971

merged 8 commits into from
Nov 9, 2023

Conversation

thyton
Copy link
Contributor

@thyton thyton commented Nov 2, 2023 •
edited
Loading

This PR supports exec in the server liveness probe. If provided, exec is preferred to httpGet as the server liveness probe handler.

@thyton thyton requested a review from a team as a code owner November 2, 2023 18:16
tvoran
tvoran reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!

It's also good to include a description in a PR like this, even if it's short.

CHANGELOG.md Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
thyton and others added 2 commits November 2, 2023 12:52
@thyton @tvoran
Update CHANGELOG.md
bef5986 
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
@thyton
move execCommand to below path and port of httpGet
f71f257
@thyton thyton requested a review from tvoran November 2, 2023 21:18
tvoran
tvoran reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add an entry for execCommand in values.schema.json? We don't have a tool to help generate it anymore, so it needs to be done by hand.

values.yaml Outdated Show resolved Hide resolved
@thyton thyton requested a review from tvoran November 4, 2023 00:34
tvoran
tvoran approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple thoughts on wording, but feel free to ignore them. This tested great! 👍

values.schema.json Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
thyton and others added 2 commits November 9, 2023 13:34
@thyton @tvoran
Update values.yaml
d146dd1 
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
@thyton @tvoran
Update values.yaml
46f5393 
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
@thyton
Copy link
Contributor Author

thyton commented Nov 9, 2023

Thanks a lot for your feedback!

@thyton thyton merged commit 2bb6994 into main Nov 9, 2023
8 checks passed
@tvoran tvoran added this to the v0.27.0 milestone Nov 14, 2023
@tvoran tvoran mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thyton @tvoran