Stopped timer can cause certificate to never update #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the `time.NewTimer()` expires, calls to `timer.Stop()` will return `false`, but the channel will have nothing in it, causing `<-timer.C` to hang forever. This is hinted at by the docs, even though they suggest `timer.Stop()` should return true in that case. We change to a non-blocking drain so that we won't block forever. This manifests in never updating the certificate after it expires, causing TLS handshake errors. Fixes #275
swenson
force-pushed
the
vault-3095/tls-handshake-error
branch
from
d897a42
to
2ac3c06
Compare
|
How to reproduce failure:
|
tvoran
approved these changes
May 23, 2022
calvn
approved these changes
May 23, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the
time.NewTimer()expires, calls totimer.Stop()will returnfalse, but the channel will have nothing in it, causing<-timer.Ctohang forever.
This is hinted at by the docs, even though they suggest
timer.Stop()should return true in that case.
We change to a non-blocking drain so that we won't block forever.
This manifests in never updating the certificate after it expires,
causing TLS handshake errors.
Fixes #275