Add exit on error auto auth annotation #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support was added in the Vault agent in hashicorp/vault#17091 Additionally, I tested this on a cluster by adding the `vault.hashicorp.com/agent-auto-auth-exit-on-err: "true"` annotation on a pod, and observing that the agent configuration was: ```json { "auto_auth": { "method": { "type": "kubernetes", "mount_path": "auth/kubernetes", "config": { "role": "internal-app", "token_path": "/var/run/secrets/kubernetes.io/serviceaccount/token" }, "exit_on_err": true }... ```
tvoran
approved these changes
Oct 28, 2022
|
Oh and don't forget to add a changelog entry as well. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support was added in the Vault agent in hashicorp/vault#17091
Additionally, I tested this on a cluster by adding the
vault.hashicorp.com/agent-auto-auth-exit-on-err: "true"annotation on a pod, and observing that the agent configuration was:{ "auto_auth": { "method": { "type": "kubernetes", "mount_path": "auth/kubernetes", "config": { "role": "internal-app", "token_path": "/var/run/secrets/kubernetes.io/serviceaccount/token" }, "exit_on_err": true }...