Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to shared raft-boltdb library and add metrics #11269

Merged
merged 18 commits into from
Apr 26, 2021
Merged

Conversation

raskchanky
Copy link
Contributor

I didn't see any kind of run loop or built-in mechanism for executing tasks on a repeating interval so this is what I came up with. Is this the right approach?

@raskchanky raskchanky requested review from briankassouf and a team April 2, 2021 21:06
@ncabatoff
Copy link
Collaborator

Side note: it looks like hashicorp/raft-boltdb#22 is going to be merged soon, and there is talk of us switching to using it and junking our local embedded copy of it, which you're modifying here. In which case maybe we should forget about using metricsutil as I was suggesting in my comment, since the way you're doing it now will lend itself better to being applied to raft-boltdb as a standalone library.

@vercel vercel bot temporarily deployed to Preview – vault April 20, 2021 01:16 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 20, 2021 01:16 Inactive
command/server.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault April 21, 2021 18:59 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 21, 2021 18:59 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 21, 2021 19:02 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 21, 2021 19:02 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 21, 2021 23:29 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 21, 2021 23:29 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 22, 2021 00:48 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 22, 2021 00:48 Inactive
@raskchanky raskchanky changed the title Emit metrics from bolt_store Switch to shared raft-boltdb library and add metrics Apr 22, 2021
@vercel vercel bot temporarily deployed to Preview – vault April 22, 2021 00:55 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 22, 2021 00:55 Inactive
@raskchanky raskchanky marked this pull request as ready for review April 22, 2021 00:55
physical/raft/raft.go Outdated Show resolved Hide resolved
physical/raft/raft.go Outdated Show resolved Hide resolved
physical/raft/raft.go Outdated Show resolved Hide resolved
physical/raft/raft.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault April 26, 2021 18:03 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 26, 2021 18:03 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 26, 2021 18:25 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 26, 2021 18:25 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 26, 2021 19:21 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 26, 2021 19:21 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 26, 2021 22:06 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 26, 2021 22:06 Inactive
@raskchanky raskchanky merged commit b6cf983 into master Apr 26, 2021
@raskchanky raskchanky deleted the boltdb-metrics branch April 26, 2021 23:01
@briankassouf briankassouf added this to the 1.8 milestone Apr 26, 2021
ncabatoff added a commit that referenced this pull request Jul 29, 2021
ncabatoff added a commit that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants