-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to shared raft-boltdb library and add metrics #11269
Conversation
Side note: it looks like hashicorp/raft-boltdb#22 is going to be merged soon, and there is talk of us switching to using it and junking our local embedded copy of it, which you're modifying here. In which case maybe we should forget about using metricsutil as I was suggesting in my comment, since the way you're doing it now will lend itself better to being applied to raft-boltdb as a standalone library. |
30e26b9
to
853b8a4
Compare
32bcdc7
to
8d3c1ef
Compare
I didn't see any kind of run loop or built-in mechanism for executing tasks on a repeating interval so this is what I came up with. Is this the right approach?