Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for db connection file type fields #11331

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Fixes for db connection file type fields #11331

merged 1 commit into from
Apr 9, 2021

Conversation

arnav28
Copy link
Contributor

@arnav28 arnav28 commented Apr 9, 2021

  1. Fixed helper text for file type form fields

Screen Shot 2021-04-09 at 10 58 28 AM

  1. Added padding to bottom form section

Screen Shot 2021-04-09 at 10 58 17 AM

@arnavpalnitkar
Fixes for db connection file type field
aa1a1c5 
- Fixed helper text for file type form fields
- Added padding bottom to form section
@Monkeychip Monkeychip added this to the 1.7.1 milestone Apr 9, 2021
@Monkeychip Monkeychip added the ui label Apr 9, 2021
Monkeychip
Monkeychip approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I've gone ahead and added the milestone and the label ui. These are two labels we try to add for each PR and they're easy to forget :)

image

@arnav28 arnav28 merged commit 79734c5 into master Apr 9, 2021
catsby added a commit that referenced this pull request Apr 14, 2021
@catsby
Merge branch 'master' into f-embed-assets
9430d67 
* master: (78 commits)
  docs: update vault-helm to 0.11.0 (#11355)
  Add documentation for vault-csi-provider namespace config (#11344)
  docs: update vault-k8s to 0.10.0 (#11354)
  patch(docs): fix link color (#11352)
  Add TFE/TFC auth plugin to plugin portal (#11348)
  fix a couple typos (#11343)
  TLS Diagnose Formatting Fixes  (#11342)
  Add More TLS Tests and Verification of TLS Root Certificate (#11300)
  Add HA only autopilot to changelog (#11339)
  Support autopilot when raft is for HA only (#11260)
  Fixes for db connection file type field (#11331)
  Fix flakey TestAgent_Template_Retry test (#11332)
  Darwin/ARM64 build target (#11321)
  Fix broken OIDC Providers link (#11327)
  Bug: DB secret engine not showing "Select one" in role select options (#11294)
  bumping alpine version, improving security (#11271)
  Run a more strict formatter over the code (#11312)
  docs: add persistent cache (#11272)
  Fix a few static analysis findings (#11307)
  Changing from "changelog" to "release-note" (#11303)
  ...
@arnav28 arnav28 deleted the ui/db-connection-style branch June 15, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@arnav28 @Monkeychip @arnavpalnitkar