Backport of Show generate creds for static-roles when you have read permissions into release/1.13.x #19225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-12528/bug-static-cred-generate/entirely-finer-swan
branch
2 times, most recently
from
41068d5 to
30bbe87
Compare
Monkeychip
approved these changes
Feb 16, 2023
Monkeychip
deleted the
backport/ui/VAULT-12528/bug-static-cred-generate/entirely-finer-swan
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19190 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
Bug fix for showing the Generate Creds/Get Credentials button for both dynamic and static roles. Before it was only showing the button for dynamic roles.
Backporting note: If this PR is approved, I'll remove the test coverage and backport everything else 3 releases. Then I'll make another PR for just the test coverage that will not get backported. I cannot backport the test coverage because I'm using a very handy (thank you Chelsea) method for stubbing the capabilities-self endpoint that was added in the 1.13. I could have added to the existing acceptance test, but we've had problems with race conditions in that test. Additionally, the actual fix was better tested in a component test.
I won't add the backport labels until after I remove the test.
creds.mov
Overview of commits