Backport of Add missing cert auth ocsp read data into release/1.13.x #20157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/cipherboy-add-missing-cert-auth-ocsp-read-data/kindly-allowed-lioness
branch
from
8ebacef to
7eaabc7
Compare
cipherboy
approved these changes
Apr 13, 2023
…t-auth-ocsp-read-data/kindly-allowed-lioness
…t-auth-ocsp-read-data/kindly-allowed-lioness
…t-auth-ocsp-read-data/kindly-allowed-lioness
cipherboy
deleted the
backport/cipherboy-add-missing-cert-auth-ocsp-read-data/kindly-allowed-lioness
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20154 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
Per conversation with @hellobontempo, cert auth UI uses the open API data to determine fields. In our case, these fields were already present, but we needed to return them from the read API response status for them to be visible in the UI. Otherwise, they'd be set server side (on the first submission), but any further changes would potentially overwrite them as the UI would use default/zero values for the fields it doesn't see.
Overview of commits