Backport of User Lockout Perf Standby Error oss into release/1.13.x #20868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/vault-16051-oss/newly-nice-snapper
branch
from
7429b74 to
c531a22
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/vault-16051-oss/newly-nice-snapper
branch
from
0a5a391 to
d31c433
Compare
akshya96
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20783 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
Jira : https://hashicorp.atlassian.net/browse/VAULT-16051
This PR contains the following fixes:
Perf Standbys no longer try to update storage directly in places where we missed it. Checked if this happens for clean up and cleanups are already being handled the right way (updated comments to make this clear)
Updated the updateUserFailedLoginInfo to handle updates to both updateUserFailedLoginInfo map and storage.
We now check if the userlockout feature is disabled after login failure.
Added tests for namespaces (wherever missing), perf standbys, approle with batch tokens, disable env var test in external tests.
Ent branch: https://github.com/hashicorp/vault-enterprise/pull/4020
Overview of commits