-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add canonicalArn as a entity alias name #22460
Add canonicalArn as a entity alias name #22460
Conversation
Hello! I know this has been sitting for a while, and for that I apologize. This looks pretty good so far, although my understanding is there is a potential concern regarding the possibility that a future entity could be created with the same canonical ARN, and inherit access unexpectedly. As a result we'd like some documentation added to Unfortunately I don't think I can make change suggestions on unchanged files, or I would offer one directly. |
ef6aa74
to
d81f6bf
Compare
Hi @kpcraig, I have added the docs as requested. Please let me know if any more changes are needed. Regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates; again, sorry for the delay!
this probably wants a changelog but i'll put it in separately. |
Hi,
This is another quality of life change. Using the assumed-role arn as the full_arn option has issues,
if you want predictable entity alias names -> in the case of EC2 and Code Build this is not the case.
This change adds canonical_arn as another option for identity configuration in addition to the others for IAM alias.
Thanks