Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP Listener: fix bug in parsing TCP listener settings for proxy_protocol_behavior #27459

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

peteski22
Copy link

@peteski22 peteski22 commented Jun 12, 2024

Description

This PR fixes a bug which prevented Vault server from starting with TCP listener configuration that attempted to set proxy_protocol_behavior to deny_unauthorized, which is part of the public Vault documentation.

Previously the expected setting during parsing was deny_authorized which was incorrect.

Docs screenshot for safety:
image

Resolves: #26439

…nauthorized' rather than 'deny_authorized' which was incorrect
@peteski22 peteski22 added bug Used to indicate a potential bug backport/ent/1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent core/config labels Jun 12, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 12, 2024
Copy link

github-actions bot commented Jun 12, 2024

CI Results:
All Go tests succeeded! ✅

@peteski22 peteski22 marked this pull request as ready for review June 12, 2024 15:08
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :)

Copy link

Build Results:
All builds succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent bug Used to indicate a potential bug core/config hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deny_unauthorized is not allowed as a proxy protocol behavior
2 participants