Handle Query Updates #27547
Merged
Handle Query Updates #27547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
|
I was confused about why no tests were failing, before realizing that there's a bug in the implementation which is fixed here: #27549. |
divyaac
force-pushed
the
VAULT-28026_Handle_Query_Updates
branch
from
6e2e51a
to
3d1fb66
Compare
miagilepner
reviewed
Jun 21, 2024
This reverts commit b67969c.
Added some tests to activity_log_test.go to verify some of these values (as I mentioned in the ent pr, this is a little iffy cause they're estimations. But i used a similar error margin approach.) |
miagilepner
reviewed
Jul 2, 2024
vault/external_tests/upgrade_testing/upgrade_testing_binary/upgrade_test.go
Outdated
Show resolved
Hide resolved
miagilepner
reviewed
Jul 2, 2024
This reverts commit 4932979.
divyaac
force-pushed
the
VAULT-28026_Handle_Query_Updates
branch
from
2210441
to
8dafa2d
Compare
miagilepner
reviewed
Jul 3, 2024
This reverts commit 8dafa2d.
6 tasks
divyaac
added
backport/ent/1.15.x+ent
backport/ent/1.16.x+ent
miagilepner
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Simplify handle query to return updated estimation values * Added changelog * remove comment * Revert "Simplify handle query to return updated estimation values" This reverts commit b67969c. * temp * Revert "temp" This reverts commit 4932979. * CE files handle query update * Revert "CE files handle query update" This reverts commit 8dafa2d. * CE Changes * Delete vault/external_tests/upgrade_testing/upgrade_testing_binary/upgrade_test.go
miagilepner
added a commit
that referenced
this pull request
Aug 15, 2024
* Handle Query Updates (#27547) * Simplify handle query to return updated estimation values * Added changelog * remove comment * Revert "Simplify handle query to return updated estimation values" This reverts commit b67969c. * temp * Revert "temp" This reverts commit 4932979. * CE files handle query update * Revert "CE files handle query update" This reverts commit 8dafa2d. * CE Changes * Delete vault/external_tests/upgrade_testing/upgrade_testing_binary/upgrade_test.go * Sort namespaces, mounts, and clients before adding them to HLL (#28062) * sort namespaces and mounts before adding them * also sort clients * add comments * pr comment fixes * changelog * changelog update * cleanup after handlequery changes (#27776) * Show Current Month When Future Month Start Date is Provided (#28042) * Show current month data * Added changelog * Edited changelog * Client Count Docs Updates/Cleanup (#27862) * Docs changes * More condensation of docs * Added some clarity on date ranges * Edited wording' * Added estimation client count info * Update website/content/api-docs/system/internal-counters.mdx Co-authored-by: miagilepner <mia.epner@hashicorp.com> --------- Co-authored-by: miagilepner <mia.epner@hashicorp.com> --------- Co-authored-by: divyaac <divya.chandrasekaran@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change HandleQuery so as to return the updated current month estimation values.
Tests are available in the matching ENT PR.
Matching ENT Pr: https://github.com/hashicorp/vault-enterprise/pull/6102
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabelsinstead of the old style
backport/x.x.xlabels.the normal
backport/x.x.xlabel (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.