Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only strip v1 prefix from path if present #28669

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

ccapurso
Copy link
Contributor

@ccapurso ccapurso commented Oct 10, 2024

Description

Jira: VAULT-29023

This PR fixes a panic that occurs when due to how path prefix trimming works. Test coverage exists within https://github.com/hashicorp/vault-enterprise/pull/6833.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@ccapurso ccapurso added backport/ent/1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Oct 10, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

CI Results:
All Go tests succeeded! ✅

@ccapurso ccapurso added this to the 1.18.1 milestone Oct 10, 2024
@ccapurso ccapurso marked this pull request as ready for review October 10, 2024 14:31
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a take-it-or-leave-it for the changelog :)

changelog/28669.txt Outdated Show resolved Hide resolved
@ccapurso ccapurso changed the title gonly strip v1 prefix from path if present only strip v1 prefix from path if present Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

Build Results:
All builds succeeded! ✅

@ccapurso ccapurso merged commit 458de6d into main Oct 10, 2024
90 checks passed
@ccapurso ccapurso deleted the vault-29023-fix-ns-trim-path branch October 10, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants