fix: errcheck for parsing CLI flags with FlagSet() #28692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various code paths in the repository depend on
apiClientMeta.FlagSet()but they do not check the return value offlags.Parse(). A parse error will be hidden from the end-user and the execution continues. With this change execution fails ifflags.Parse()returns an error.This issue is more wide-spread and affects various HashiCorp Vault related repositories. Originally I noticed this in hashicorp/vault-plugin-auth-kubernetes#202.
TODO only if you're a HashiCorp employee
Not a HashiCorp employee :-)