Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove hashicorp-forge/bbolt and replace with official beta release (… #28963

Open
wants to merge 2 commits into
base: release/1.18.x
Choose a base branch
from
Open

remove hashicorp-forge/bbolt and replace with official beta release (… #28963

wants to merge 2 commits into from
+85 −114

Conversation

raskchanky
Copy link
Contributor

@raskchanky raskchanky commented Nov 19, 2024 •
edited
Loading

Description

This backports #28916 to 1.18. Note that because etcd-io/bbolt 1.4, which we now depend on, requires Go 1.23.x, I've included #28920 as part of this backport.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@raskchanky
remove hashicorp-forge/bbolt and replace with official beta release (#…
8c78558 
…28916)

* remove hashicorp-forge/bbolt and replace with official beta release

* get rid of redundant method

* go mod tidy

* make proto
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 19, 2024
@raskchanky raskchanky added this to the 1.18.3 milestone Nov 19, 2024
@stevendpclark @raskchanky
Update to Go 1.23.3 (#28920)
fa5e6e5 
* Update to Go 1.23.3

 - Update to latest major version of Go 1.23.3 from 1.22.8.
 - Update github.com/sasha-s/go-deadlock to address deadlock timer
   issue we were seeing.
 - Fix one of our tests to only reset the member variable we change
   instead of the entire Opts parameter to avoid a data race during
   testing.

* Add workaround for MSSQL TLS certificate container issue
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

@raskchanky raskchanky requested review from stevendpclark and a team November 19, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendpclark stevendpclark Awaiting requested review from stevendpclark

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.18.3
Development

Successfully merging this pull request may close these issues.
2 participants
@raskchanky @stevendpclark