UI: Update PostgreSQL database params #29200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
added
backport/ent/1.16.x+ent
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
hellobontempo
commented
Dec 17, 2024
|
|
||
| // If we refactor the database/connection model we can use this const in the updated form component | ||
| // Ideal scenario be the API provides this schema so we don't have to manually write :) | ||
| const EXPECTED_FIELDS = { |
There was a problem hiding this comment.
This could be moved to a test helper file, but decided to hold off unless we plan to use it elsewhere?
I wrote this test coverage before adding the _filterFields function to the database/connection model
hellobontempo
changed the title
Monkeychip
reviewed
Dec 17, 2024
| return expandAttributeMeta(this, fields); | ||
| }), | ||
|
|
||
| // after checking for enterprise, filter callback fires and returns |
There was a problem hiding this comment.
I like this approach. nice.
hellobontempo
commented
Dec 18, 2024
Monkeychip
reviewed
Dec 18, 2024
Monkeychip
reviewed
Dec 18, 2024
Monkeychip
previously approved these changes
Dec 18, 2024
Monkeychip
approved these changes
Dec 18, 2024
6 tasks
Monkeychip
pushed a commit
that referenced
this pull request
Dec 18, 2024
* add testing before model changes * add enterprise self_managed attr, update tests * add postgres params * add changelog * update test * cleanup filter function * fix nits
hellobontempo
added a commit
that referenced
this pull request
Dec 18, 2024
* add testing before model changes * add enterprise self_managed attr, update tests * add postgres params * add changelog * update test * cleanup filter function * fix nits
6 tasks
hellobontempo
removed
backport/ent/1.16.x+ent
hellobontempo
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added some missing params to PostgreSQL:
tls_caself_managed(Enterprise only)disable_escapingpassword_authenticationauth_typeservice_account_jsonuse_private_ipprivate_keytls_certificateTODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.