credsutil: Include underscore as part of reqStr #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
changed the title
|
Changed to use underscore because Cassandra doesn't like "-" for their usernames unless the statement wraps the username with double quotes. I feel like |
|
I think we landed on using a hyphen since any backends that need underscores instead already do that conversion? Or am I misremembering? |
|
That's right. I was getting CI errors for the cassandra db plugin because the character conversion for the username was not ported over, but it's now fixed. |
jefferai
approved these changes
Aug 3, 2017
chrishoffman
pushed a commit
that referenced
this pull request
Aug 8, 2017
* oss/master: (55 commits) update dr replication docs with the promotion response (#3124) Make travis_wait Travis wait longer_wait changelog++ Set allowed headers via API instead of defaulting to wildcard. (#3023) Fix formatting in mfa docs (#3122) Fix minor typo (#3120) Update go-plugin to include go-hclog support Unlock the statelock on unsuccessful sealInitCommon Remove a couple unneeded cancels Make seal/stepdown functions async internally so they can poke the request context Update mock-plugin (#3107) Fix minor grammatical error (#3110) docs: MFA API (#3109) Cut version 0.8.0-rc1 Update version Migrate physical backends into separate packages (#3106) changeling ++ changelog++ changelog++ credsutil: Include hyphen as part of reqStr (#3037) ...
issacg
added a commit
to ironSource/vault-redshift-plugin
that referenced
this pull request
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3036