Add setting for workspace root module configuration #423
Conversation
|
Depends on hashicorp/terraform-ls#189 |
| const reloadMsg = "Reload VSCode window to apply language server changes"; | ||
| vscode.window.showInformationMessage(reloadMsg, "Reload").then((selected) => { | ||
| if (selected === "Reload") { | ||
| vscode.commands.executeCommand("workbench.action.reloadWindow"); |
There was a problem hiding this comment.
Why does this need to restart, why can't we just use the configuration RPC hook?
There was a problem hiding this comment.
Just read the LS issue, this is fine if its just the initial implementation and we can improve it over time.
There was a problem hiding this comment.
@radeksimko and I talked through it this morning, this is the simplest option to start with. We'll have to stagger the language server and extension releases to deploy this, so it makes the most sense to do something we know we can ship on the language server quickly.
There was a problem hiding this comment.
The reload will still be necessary with the latest proposed solution (which involves initializationOptions), there's some context here to explain why:
hashicorp/terraform-ls#189 (comment)
Co-authored-by: Paul Tyng <ptyng@hashicorp.com>
| const reloadMsg = "Reload VSCode window to apply language server changes"; | ||
| vscode.window.showInformationMessage(reloadMsg, "Reload").then((selected) => { | ||
| if (selected === "Reload") { | ||
| vscode.commands.executeCommand("workbench.action.reloadWindow"); |
There was a problem hiding this comment.
The reload will still be necessary with the latest proposed solution (which involves initializationOptions), there's some context here to explain why:
hashicorp/terraform-ls#189 (comment)
Co-authored-by: Paul Tyng <ptyng@hashicorp.com>
|
Quick question, will this support wildcards? I have a directory of directories named "something.standard.suffix" and I'd love to just pick them all up with "terraform.rootModules" : "*.standard.suffix". I'd be up for trying to add this myself too if that's out of scope for this PR |
Not on the first round, and we're still examining which parts of this should be handled by the extension and which by the language server. If you want to create an issue with your use case, that would be helpful! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked and limited conversation to collaborators
Closes #396