chore: update tests to pass the race detector and linter #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should allow them to pass with the race detector.
Let's see if I remember how to yaml
schmichael
approved these changes
Aug 5, 2024
tgross
approved these changes
Aug 5, 2024
| - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0 | ||
| - uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # v3.5.0 | ||
| with: | ||
| go-version: '1.20' |
There was a problem hiding this comment.
I just copied and pasted raft's as a basis assuming they're the best maintained shared library. 😬 We can bump it. I'm not really sure what the optimal strategy is for a little library like this with no deps and no-post-1.14 features afaik.
Co-authored-by: Michael Schurter <michael.schurter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now passes:
golangci-lint run ./...go test -race ./... -shortThe
-shortis needed because both ofTestSendData_VeryLargeandTestSendData_Largefail for timing reasons (since race mode is generally slower) and I was hesitant to rewrite them to be less timing sensitive, so I have them get skipped when in testing short mode for now.