Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust toolchains for /libs to nightly-2023-05-08 #2521

Merged
merged 5 commits into from
May 8, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 8, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
rust minor 2023-04-17 -> 2023-05-08

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from a team as code owners May 8, 2023 09:15
@github-actions github-actions bot added area/libs > antsi Affects the `antsi` crate (library) area/libs > deer Affects the `deer` crate (library) area/libs > error-stack Affects the `error-stack` crate (library) area/libs > sarif Affects the `sarif` crate (library) labels May 8, 2023
@TimDiekmann
Copy link
Member

@indietyp could you take a look at the failing CIs for antsi and deer please?

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #2521 (925a461) into main (228a100) will increase coverage by 0.36%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2521      +/-   ##
==========================================
+ Coverage   55.59%   55.95%   +0.36%     
==========================================
  Files         331      319      -12     
  Lines       26909    26636     -273     
  Branches      453      412      -41     
==========================================
- Hits        14959    14904      -55     
+ Misses      11945    11731     -214     
+ Partials        5        1       -4     
Flag Coverage Δ
antsi 0.00% <ø> (-0.36%) ⬇️
backend-integration-tests 3.66% <ø> (ø)
deer 66.45% <100.00%> (-0.04%) ⬇️
error-stack 82.54% <ø> (-0.02%) ⬇️
hash-status 0.00% <ø> (-2.71%) ⬇️
sarif 100.00% <ø> (ø)
unit-tests 0.00% <ø> (-1.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/error-stack/src/lib.rs 33.33% <ø> (-5.13%) ⬇️
libs/deer/src/impls/core/array.rs 75.22% <100.00%> (ø)
libs/deer/src/lib.rs 70.48% <100.00%> (-0.11%) ⬇️

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@indietyp
Copy link
Member

indietyp commented May 8, 2023

antsi: const traits are getting ripped out of Rust (rust-lang/rust#111275, rust-lang/rust#110393), pending a rework. This needs a separate PR that removes them from the codebase. There is currently no equivalent AFAIK, which means we need to do a bit of rethinking.

Removal tracked in rust-lang/rust#110395

@renovate
Copy link
Contributor Author

renovate bot commented May 8, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@TimDiekmann TimDiekmann requested a review from indietyp May 8, 2023 11:06
@TimDiekmann TimDiekmann enabled auto-merge May 8, 2023 11:09
@TimDiekmann TimDiekmann added this pull request to the merge queue May 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2023
@TimDiekmann TimDiekmann enabled auto-merge May 8, 2023 20:28
@TimDiekmann TimDiekmann added this pull request to the merge queue May 8, 2023
Merged via the queue into main with commit 6706559 May 8, 2023
@TimDiekmann TimDiekmann deleted the renovate/rust-libraries-toolchains branch May 8, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > antsi Affects the `antsi` crate (library) area/libs > deer Affects the `deer` crate (library) area/libs > error-stack Affects the `error-stack` crate (library) area/libs > sarif Affects the `sarif` crate (library)
Development

Successfully merging this pull request may close these issues.

2 participants