-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEN-108: Add a simple example for new error-stack users starting new project #3228
Conversation
c955daf
to
86c1007
Compare
Codecov Report
@@ Coverage Diff @@
## main #3228 +/- ##
========================================
+ Coverage 1.23% 2.30% +1.06%
========================================
Files 112 120 +8
Lines 3792 4038 +246
Branches 456 495 +39
========================================
+ Hits 47 93 +46
- Misses 3743 3939 +196
- Partials 2 6 +4
Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution. I think I'm sold on using thiserror
in this context, otherwise, 4 additional impl
blocks would have been required.
Happy to approve as soon as linting is passing (rustfmt
is currently failing).
86c1007
to
7918d23
Compare
7918d23
to
ad8e6ea
Compare
ad8e6ea
to
5b07a07
Compare
Thank you. Fixed (passes locally). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you!
We can merge the PR as soon as the CLA is signed.
Btw, there is no need to force-push to rewrite the history of a PR, we squash merge anyway to keep a clean history in main
.
Oh. I missed that. Done. |
Fix #3209
🌟 What is the purpose of this PR?
As a ever-re-returning user that wants to start a new project
using error-stack, I open http://docs.rs/error-stack and get
lots of words explaining some details, and not a single basic
example that would get me going.
This PR adds the simple example code that I'm looking always
looking for.
🛡 What tests cover this?
cargo test --doc
:)