Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type class for different auth methods #365

Merged
merged 1 commit into from
May 23, 2019

Conversation

robbiemcmichael
Copy link
Contributor

Adds a type class which allows users of the library to define alternative authentication methods. This is required to support JWT auth which is required by GitHub Apps, however we may not want to add GitHub app support to this library directly since they are currently part of GitHub's API previews which are not stable.

Copy link
Contributor

@phadej phadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Exactly in a spirit "provide means to extend existing functionality"

@phadej phadej merged commit c969f0a into haskell-github:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants