Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for constant-space NAR processing #10

Closed
imalsogreg opened this issue May 6, 2018 · 5 comments
Closed

Add tests for constant-space NAR processing #10

imalsogreg opened this issue May 6, 2018 · 5 comments

Comments

@imalsogreg
Copy link
Collaborator

When working with NARs that are large, we want to test that our serialization/deserialization can work in constant space. This can be achieved with a run of the test suite with RTS parameters limiting the heap size, e.g. ./space-tests +RTS -K100K (taken from http://neilmitchell.blogspot.com/2015/09/detecting-space-leaks.html)

@shlevy Could you add links to this ticket to issues in nix tooling where memory issues affected NAR processing? Those could suggest test fixtures and specific regression tests for us.

@shlevy
Copy link
Member

shlevy commented May 9, 2018

@imalsogreg
Copy link
Collaborator Author

Thanks for the examples!

We now have constant-space streaming tests for large files in #7

@imalsogreg
Copy link
Collaborator Author

Closed by #7

@ryantrinkle
Copy link
Member

Wow, this is awesome! Thanks guys - just got bit by NixOS/nix#1988

@nh2
Copy link

nh2 commented Jun 3, 2018

I made a PR that should fix (at least one more part) of that in nix: NixOS/nix#2206

Anton-Latukha added a commit to Anton-Latukha/hnix-store that referenced this issue Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants