Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try Apple AArch64 again #10363

Merged
merged 1 commit into from
Sep 28, 2024
Merged

try Apple AArch64 again #10363

merged 1 commit into from
Sep 28, 2024

Conversation

geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Sep 16, 2024

Let's see if the runner has stabilized yet. Also, fixed the arch issues (validate no longer assumes everything is x86_64).

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur geekosaur changed the title try Apple AArch64 again WIP: try Apple AArch64 again Sep 16, 2024
@geekosaur geekosaur force-pushed the try-aarm-again branch 5 times, most recently from 0263ffe to 4c98ddb Compare September 17, 2024 21:05
@ulysses4ever
Copy link
Collaborator

It'd be great to have this working and add it to the set of pre-release binaries. Many people are using ARM silicon from Apple these days.

Godspeed!

@geekosaur
Copy link
Collaborator Author

If you look at it, adding it to the prerelease (and adding support for archs other than x86_64 in the process) is part of what this PR does.

@geekosaur
Copy link
Collaborator Author

It's a good sign that it's now the Windows jobs that are slowest. (That one someone like jasagredo will have to figure out.)

@geekosaur
Copy link
Collaborator Author

Question: a large part of my objective here was to speed up the Mac builds, but in the process all the Intel builds were lost. Do we want to support those some other way (e.g. overnight builds), or re-add them for the ghcs that only work on Intel, or something else?

@geekosaur geekosaur force-pushed the try-aarm-again branch 2 times, most recently from 03e73d9 to e6874b7 Compare September 18, 2024 00:29
@geekosaur geekosaur marked this pull request as ready for review September 18, 2024 00:30
@geekosaur geekosaur changed the title WIP: try Apple AArch64 again try Apple AArch64 again Sep 18, 2024
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Sep 26, 2024
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Sep 26, 2024
Let's see if the runner has stabilized yet. Also, fixed the arch
issues (validate no longer assumes everything is x86_64).
@mergify mergify bot merged commit 1c93fb5 into haskell:master Sep 28, 2024
48 checks passed
@geekosaur
Copy link
Collaborator Author

@mergify backport 3.12

Copy link
Contributor

mergify bot commented Oct 1, 2024

backport 3.12

✅ Backports have been created

@geekosaur
Copy link
Collaborator Author

@mergify backport 3.14

Copy link
Contributor

mergify bot commented Oct 1, 2024

backport 3.14

✅ Backports have been created

@Mikolaj
Copy link
Member

Mikolaj commented Oct 2, 2024

Do we want to support those some other way (e.g. overnight builds), or re-add them for the ghcs that only work on Intel, or something else?

I think, given the complexity of our CI and how often it breaks (including due to external reasons), optimizing for CI maintenance should be the priority and compromises are fine (e.g., only running some tests on Intel Macs). It's better to have less exhaustive CI that works and doesn't consume all out maintenance budget than the other way around. So I support your approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-backport 3.14 continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge platform: mac ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants