-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haddock-project
: add CommonSetupFlags
#10393
haddock-project
: add CommonSetupFlags
#10393
Conversation
f2afeea
to
89cb6a8
Compare
haddock-project
: add CommonFlags
haddock-project
: add CommonSetupFlags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: API change, can't be backported.
89cb6a8
to
7fa0e5e
Compare
7fa0e5e
to
14510a9
Compare
I am not sure this is the right direction of travel -- why are we propagating the design flaw of reusing the options parsers for the |
14510a9
to
5730083
Compare
I can't comment on the design here, but all the other |
@coot ping |
Maybe we should have a label for this case... |
This PR is not the best time and place to discuss such a big, long-standing issue. I'd prefer this be merged and have the issue discussed separately. But I rarely touch |
I agree we should eventually reconsider flag design, but this is not the place. For now let's proceed with the way things are, and it would be good to file an issue for a future refactor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5730083
to
e410770
Compare
Rebased for mergify permissions |
@9999years , you need to rebase again; see #10445. |
e410770
to
f84087a
Compare
Split off of #10292. This lets
cabal haddock-project
use the standardCommonFlags
that other commands use to set verbosity and so on.