Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new non-compile-affecting options for ghc 9.12 #10468

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Oct 17, 2024

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

@geekosaur
Copy link
Collaborator Author

Does anyone know if I need to add special parsing somewhere for -pgmJSP, -optJSP, etc. somewhere? I believe we parse ghc-options contents to determine recompilation necessity and compute hashes?

@geekosaur
Copy link
Collaborator Author

Okay, already need another change, -fwrite-if-compression both changes the store (although supposedly not the meaning) and takes a numeric arg.

@geekosaur
Copy link
Collaborator Author

I suppose I won't hear anything until Monday at earliest, but with a little more understanding on my side: do we care about the new -pgmJSP and -optJSP… options? I know we support GHCJS, but I'm not sure we do anything with the new JS backend and at this point I don't see any way to support those options even as far as hashing them without a pretty major API break. That said, I also don't see what supporting them would do without some even more major changes to the build logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants