Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace issue in changelog #10642

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix whitespace issue in changelog #10642

merged 1 commit into from
Dec 16, 2024

Conversation

alt-romes
Copy link
Collaborator

@alt-romes alt-romes commented Dec 16, 2024 •
edited
Loading

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@alt-romes
Copy link
Collaborator Author

@geekosaur here it is

@alt-romes alt-romes mentioned this pull request Dec 16, 2024
Open
6 tasks
geekosaur
geekosaur requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a PR template, please.

@alt-romes
Copy link
Collaborator Author

Added

@geekosaur
Copy link
Collaborator

geekosaur commented Dec 16, 2024 •
edited
Loading

High priority because in some sense master is currently broken / doesn't pass CI since changelog.d was added to the whitespace check, and in particular other PRs will block on this until master is updated and they are rebased. See #10639 (comment).

@Mikolaj
Copy link
Member

Mikolaj commented Dec 16, 2024

If nobody objects I will expedite the merge in a moment, as @geekosaur suggests.

@geekosaur
Copy link
Collaborator

Just set merge me, Mergify already knows about priority: high.

@alt-romes alt-romes added the merge me Tell Mergify Bot to merge label Dec 16, 2024
@mergify mergify bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period labels Dec 16, 2024
@mergify mergify bot merged commit 3727226 into haskell:master Dec 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@philderbeast philderbeast philderbeast approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge priority: high 🔥 ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alt-romes @geekosaur @Mikolaj @philderbeast