Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment optional post-install field in the ghcup metadata script and fix typos #10643

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Comment optional post-install field in the ghcup metadata script and fix typos #10643

wants to merge 4 commits into from
+19 −30

Conversation

Kleidukos
Copy link
Member

No description provided.

@Kleidukos Kleidukos mentioned this pull request Dec 16, 2024
Merged
@Kleidukos Kleidukos requested a review from geekosaur December 17, 2024 00:19
@Kleidukos
Copy link
Member Author

@geekosaur A second look would be appreciated

@Kleidukos
Copy link
Member Author

cc @arjunkathuria

geekosaur
geekosaur approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay as far as I can tell, but I'm not really an expert in ghcup's YAML metadata.

@Kleidukos Kleidukos force-pushed the fixes-to-the-ghcup-metadata-script branch from 430274a to ae0455a Compare December 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kleidukos @geekosaur