Remove --allow-{newer,older} support from Cabal #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparatory refactoring needed for future work such as haskell#4203. I've refrained from doing additional cleanups in order to keep this a refactoring that mostly moves around blocks of code mostly unchanged (except for whitespace), and make it easier to review. This feature was originally implemented because its lack was complained about by Stack/Stackage developers. However, after it got implemented it was never really being used; what's more, it's causing us overhead for no benefit as well as blocking us improving the implementation via the likes of haskell#4203. Closes haskell#3581
|
@hvr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dcoutts, @pepeiborra and @ezyang to be potential reviewers. |
|
@23Skidoo Travis is green! Do you want to review this PR or can I merge it rightaway? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparatory refactoring needed for future work such as #4203.
I've refrained from doing additional cleanups in order to keep this a
refactoring that mostly moves around blocks of code mostly
unchanged (except for whitespace), and make it easier to review.
This feature was originally implemented because its lack was complained
about by Stack/Stackage developers. However, after it got implemented it
was never really being used; what's more, it's causing us overhead for
no benefit as well as blocking us improving the implementation via the
likes of #4203.
Closes #3581