Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests and benchs by default on new-install #4879

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Nov 9, 2017

And error if they are explicitly enabled, so we never try to install
remote packages with tests and/or benchs.

Fixes #4855

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!
...no tests for new-install yet

And error if they are explicitly enabled, so we never try to install
remote packages with tests and/or benchs.

Fixes haskell#4855
@fgaz
Copy link
Member Author

fgaz commented Nov 9, 2017

It's the second time that this happens https://travis-ci.org/haskell-pushbot/cabal-binaries/builds/299703001#L655

    ShortText Id:                                                                         FAIL

      *** Failed! Falsifiable (after 100 tests and 4 shrinks): 

      "\65534"

      Use --quickcheck-replay=209006 to reproduce.

Again the U+FFFE "not a character" (reversed BOM)

@23Skidoo
Copy link
Member

23Skidoo commented Nov 9, 2017

It's a known issue, I think we had a ticket. You can ignore it. /cc @hvr

@23Skidoo
Copy link
Member

23Skidoo commented Nov 9, 2017

OK, let's merge. CI errors are spurious.

@23Skidoo 23Skidoo merged commit 6e25df3 into haskell:master Nov 9, 2017
@23Skidoo
Copy link
Member

23Skidoo commented Nov 9, 2017

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants