Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Drop build and CI support for GHC < 8.0 #7534

Closed
wants to merge 11 commits into from

Conversation

emilypi
Copy link
Member

@emilypi emilypi commented Aug 12, 2021


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@emilypi emilypi linked an issue Aug 12, 2021 that may be closed by this pull request
@emilypi
Copy link
Member Author

emilypi commented Aug 13, 2021

@fgaz do you mind taking a look at the cabal-testsuite here? It looks like the macros aren't expanding.

@@ -140,7 +140,7 @@ deleteOldExeFile verbosity oldPID tmpPath = do
++ show oldPID ++ " at path " ++ tmpPath

log $ "getting handle of parent process " ++ show oldPID
oldPHANDLE <- Win32.openProcess Win32.sYNCHORNIZE False (fromIntegral oldPID)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an uncaught bug.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was caught and fixed in Win32 long ago, but then not fixed here.

@fgaz
Copy link
Member

fgaz commented Aug 16, 2021

@fgaz do you mind taking a look at the cabal-testsuite here? It looks like the macros aren't expanding.

very odd. did you try calling the output normalizer manually on that string? what does it do?

@emilypi
Copy link
Member Author

emilypi commented Aug 16, 2021

@fgaz what's the procedure for that?

@fgaz
Copy link
Member

fgaz commented Aug 16, 2021

Not sure if there's a better way, but i'd just load cabal-testsuite/src/Test/Cabal/OutputNormalizer.hs in ghci and call normalizeOutput directly. If it works, I'd check what's wrong in the NormalizerEnv that gets passed to it (guess: normalizerKnownPackages)

@fgaz
Copy link
Member

fgaz commented Nov 23, 2021

Quoting @Mikolaj from another pr, What's the status here? How can we help to move it forward?

@fgaz
Copy link
Member

fgaz commented Feb 12, 2022

Ping! Will you still work on this @emilypi ?

@andreabedini
Copy link
Collaborator

If @emilypi is not working on this anymore, I'm happy to be assigned to this. In #7952 I have already dropped the tests for old GHCs, I need to remember to drop the support in the code.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 14, 2022

@andreabedini: yes, please, go ahead!

@andreabedini
Copy link
Collaborator

andreabedini commented Mar 17, 2022

oh boy this is going to be a big rebase :D (rolls up sleaves)

@jneira
Copy link
Member

jneira commented Apr 4, 2022

We should close this when #8079 is ready for merge, if @emilypi agrees of course

@andreabedini
Copy link
Collaborator

This work has been implemented in #8079, which has been merged. Thanks @emilypi for starting this <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Dropping build support for GHC < 8
5 participants