-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Drop build and CI support for GHC < 8.0 #7534
Conversation
@fgaz do you mind taking a look at the |
@@ -140,7 +140,7 @@ deleteOldExeFile verbosity oldPID tmpPath = do | |||
++ show oldPID ++ " at path " ++ tmpPath | |||
|
|||
log $ "getting handle of parent process " ++ show oldPID | |||
oldPHANDLE <- Win32.openProcess Win32.sYNCHORNIZE False (fromIntegral oldPID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an uncaught bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was caught and fixed in Win32 long ago, but then not fixed here.
very odd. did you try calling the output normalizer manually on that string? what does it do? |
@fgaz what's the procedure for that? |
Not sure if there's a better way, but i'd just load |
Quoting @Mikolaj from another pr, What's the status here? How can we help to move it forward? |
Ping! Will you still work on this @emilypi ? |
@andreabedini: yes, please, go ahead! |
oh boy this is going to be a big rebase :D (rolls up sleaves) |
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!