Use the cli flags in fetching packages in building a project config #7967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this need a changelog? |
A good question. Was this bug introduced since 3.6.2? I guess not? |
Kleidukos
approved these changes
Mar 12, 2022
Kleidukos
added
merge me
|
@Mergifyio rebase master |
✅ Branch has been successfully rebased |
jneira
force-pushed
the
gb/use-cli-flags-in-readLocalPackages
branch
from
2865d99 to
5c65163
Compare
…to use the http transport flag)
jneira
force-pushed
the
gb/use-cli-flags-in-readLocalPackages
branch
from
5c65163 to
8a7fa89
Compare
Merged
|
Merged without regression test? |
|
Yes, let's add the test that you describe in the issue and a changelog too. I guess we need to stop approving PRs meaning "good to go as soon as you add finishing touches", because then we forget, see an approved PR and merge as is. |
|
I made a fuss on the Matrix/IRC channel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a logic bug.
resolves #7775