Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stack.yaml resolver and fix cabal-testsuite stack build #8050

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

jneira
Copy link
Member

@jneira jneira commented Mar 16, 2022

  • No ci job is checking this but i tested it locally in debian 10
  • I had to add Cabal-syntax to setup-dependsin the cabal-testsuite or the build throwed the error:
cabal-testsuite> /home/debian/cabal/cabal-testsuite/Setup.hs:4:1: error:
cabal-testsuite>     Could not load module `Distribution.Backpack'
cabal-testsuite>     It is a member of the hidden package `Cabal-syntax-3.7.0.0'.
cabal-testsuite>     You can run `:set -package Cabal-syntax' to expose it.
cabal-testsuite>     (Note: this unloads all the modules in the current scope.)
cabal-testsuite>     It is a member of the hidden package `Cabal-3.2.1.0'.
cabal-testsuite>     You can run `:set -package Cabal' to expose it.
cabal-testsuite>     (Note: this unloads all the modules in the current scope.)
cabal-testsuite>     Use -v (or `:set -v` in ghci) to see a list of the files searched for.
cabal-testsuite>   |
cabal-testsuite> 4 | import Distribution.Backpack
cabal-testsuite>   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Copy link
Collaborator

@robx robx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

stack.yaml Show resolved Hide resolved
@jneira
Copy link
Member Author

jneira commented Mar 18, 2022

@Mergifyio rebase master

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2022

rebase master

✅ Branch has been successfully rebased

@jneira
Copy link
Member Author

jneira commented Mar 24, 2022

@Mikolaj would be this ready to go?

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't pride myself on being a stack expert, but this certainly looks very useful as a test.

@Mikolaj Mikolaj added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Mar 24, 2022
@mergify mergify bot merged commit ec6202f into haskell:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants