Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapping update (including GHC 9.0, 9.2) #8239

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

robx
Copy link
Collaborator

@robx robx commented Jun 21, 2022

This is meant to address #8225.

  • Add GHC 9.0.2 and GHC 9.2.3 to the bootstrapping GHC versions
  • Updates bootstrap files according to current hackage state
  • Updates the bootstrap CI job to test all GHC versions

I haven't tested all the bootstrap builds yet, let's see what CI says.


Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great job, if ci is green it is good to go

@robx
Copy link
Collaborator Author

robx commented Jun 21, 2022

Ah looks like this needs some Github setting update, because the jobs are no longer called "Bootstrap macos-latest" / "Bootstrap ubuntu-latest" but those are marked Required.

@Mikolaj
Copy link
Member

Mikolaj commented Jun 22, 2022

Settings updated. Once this lands, let's add the new jobs to Required.

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much.

How do we go about backporting this to 3.8 branch?

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Jun 22, 2022
robx added 2 commits June 22, 2022 08:48
- parametrize the bootstrap update Makefile target to make changing
  the list of GHC versions a bit easier
- add GHC 9.0.2 and 9.2.3 to the list of bootstrapping GHC versions
- regenerate the bootstrapping plans across all GHC versions
Keep it at only GHC 8.10.7 for macOS to save on CI time a bit.
@robx
Copy link
Collaborator Author

robx commented Jun 22, 2022

Thank you so much.

How do we go about backporting this to 3.8 branch?

It should be a matter of cherry-picking the commits, running make update-bootstrap-jsons and amending with the changed files.

@Mikolaj
Copy link
Member

Mikolaj commented Jun 22, 2022

OK, great. Let's start with a naive Mergify backport and perhaps it can be amended easily.

@Mikolaj
Copy link
Member

Mikolaj commented Jun 22, 2022

@Mergifyio backport 3.8

@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2022

backport 3.8

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify mergify bot merged commit fd6de6b into haskell:master Jun 22, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2022

backport 3.8

✅ Backports have been created

Mikolaj added a commit that referenced this pull request Jun 24, 2022
Bootstrapping update (including GHC 9.0, 9.2) (backport #8239)
Mikolaj added a commit that referenced this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-review merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants