Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify -Werror warning #8258

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Simplify -Werror warning #8258

merged 1 commit into from
Jul 1, 2022

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Jun 27, 2022 •
edited
Loading

-W -Wall is too (correctly) refused by Hackage.

Closes #8257.

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Minor: not changelog worthy.
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

andreasabel
andreasabel requested changes Jun 27, 2022
View reviewed changes
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix also the second half of the error message.

@ffaf1 ffaf1 mentioned this pull request Jun 28, 2022
Merged
3 tasks
@ffaf1 ffaf1 marked this pull request as ready for review June 28, 2022 08:05
@turion
Copy link

turion commented Jun 28, 2022

Another possibility might be joining the warning messages for -Werror and -Werror -W/-Werror -Wall into a single one, triggering only on -Werror.

@ffaf1 ffaf1 changed the title Clarify -Werr plus -W/-Wall warning Simplify -Werror warning Jun 28, 2022
@ffaf1 ffaf1 requested a review from andreasabel June 28, 2022 17:09
andreasabel
andreasabel approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@andreasabel andreasabel added the merge me Tell Mergify Bot to merge label Jul 1, 2022
@mergify mergify bot merged commit be363be into haskell:master Jul 1, 2022
@ffaf1 ffaf1 deleted the wall-werr-w branch July 1, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbaz gbaz gbaz approved these changes

@andreasabel andreasabel andreasabel approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

Assignees
No one assigned
Labels
cabal-install: cmd/check merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cabal check incorrectly assumes package has -Wall -Werror
5 participants
@ffaf1 @turion @gbaz @andreasabel @ulysses4ever