Add deprecation warnings to Nix integration #9205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvan-sraka
force-pushed
the
deprecate-nix-integration
branch
5 times, most recently
from
c37ab91
to
9cf3a97
Compare
Kleidukos
requested changes
Aug 25, 2023
yvan-sraka
force-pushed
the
deprecate-nix-integration
branch
from
9cf3a97
to
8d97abe
Compare
Kleidukos
requested changes
Aug 25, 2023
yvan-sraka
force-pushed
the
deprecate-nix-integration
branch
from
8d97abe
to
649e4fc
Compare
1 task
yvan-sraka
force-pushed
the
deprecate-nix-integration
branch
from
53ef471
to
623fd89
Compare
Kleidukos
requested changes
Sep 1, 2023
Kleidukos
approved these changes
Sep 1, 2023
|
@yvan-sraka good job, now it's time to update the CLI output test suite and it should be good |
yvan-sraka
force-pushed
the
deprecate-nix-integration
branch
from
035c0e7
to
ea553b2
Compare
Kleidukos
reviewed
Sep 2, 2023
yvan-sraka
force-pushed
the
deprecate-nix-integration
branch
5 times, most recently
from
46a9361
to
4e8a3f1
Compare
I updated the PR, now the tests are green :) |
mergify
bot
added
the
merge delay passed
Mikolaj
force-pushed
the
deprecate-nix-integration
branch
from
4e8a3f1
to
5581ff5
Compare
yvan-sraka
added a commit
to yvan-sraka/cabal
that referenced
this pull request
Sep 7, 2023
This is a follow-up of haskell#9205
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
cabalbehavior by adding deprecation warnings to Nix integration.This has been discussed on the discourse.
Checklist:
Bonus points for added automated tests!
QA Notes:
cabal --helpshould display the[DEPRECATED]label next to each Nix integration-related flag in the list ;cabal some-v1-commandwith the--enable-nixor--nix=Trueflag should display a warning about the deprecation of the feature and provide a link to the online documentation for further information.