External commands: Add tests for #9402 #9403 #9404 #9406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpickering
force-pushed
the
wip/external-command-test
branch
from
fb73d5d
to
4a3fcaa
Compare
This adds 4 tests which test the new external commands feature: * ExternalCommand - Tests the expected usage of external command invoked via cabal-install * ExternalCommandSetup - Tests that the ./Setup interface does not support external commands (haskell#9403) * ExternalCommandEnv - Tests that environment variables are set and preserved appropiately (haskell#9402) * ExternalCommandHelp - Test that `cabal help <cmd>` is interpreted appropiately (haskell#9404)
mpickering
force-pushed
the
wip/external-command-test
branch
from
4a3fcaa
to
1670aab
Compare
|
Adding tests first is a great practice. What do you intend to do with this PR? Mark the tests as failing and merge it? Keep it pending until other PRs add the features, using this PR as local tests? |
|
@Mikolaj I marked the tests as failing with pointers to the relevant issues. I was going to use them locally myself but @yvan-sraka already started implementing some changes as well so I decided to put them up. |
|
I put these tests now in #9412 which implements all the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 4 tests which test the new external commands feature:
cabal help <cmd>is interpreted appropiately (External commands:cabal help <cmd>does not work #9404)