Shuffle around Distribution.Simple.Program.Types #9544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Dec 19, 2023
sheaf
added
merge me
mergify
bot
added
the
merge delay passed
This commmit removes the dependency of the Distribution.Simple.Program.Types on Distribution.Simple.Program.Find by shuffling around a few definitions between the modules. This makes the "Types" module more self-contained, which means it can be more easily imported without causing module cycles.
Mikolaj
force-pushed
the
wip/program-types
branch
from
23fb615
to
44775ad
Compare
mstksg
pushed a commit
to mstksg/hoppy
that referenced
this pull request
May 15, 2024
simpleProgram stopped being exported from Distribution.Simple.Program.Types. It's still imported from Distribution.Simple.Program so let's refer to it there. See: haskell/cabal#9863 See: haskell/cabal#9544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commmit removes the dependency of the
Distribution.Simple.Program.Types on Distribution.Simple.Program.Find by shuffling around a few definitions between the modules.
This makes the "Types" module more self-contained, which means it can be more easily imported without causing module cycles.