Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render project configs as clean list in provenance message #9985

Merged
merged 1 commit into from
May 17, 2024

Conversation

philderbeast
Copy link
Collaborator

@philderbeast philderbeast commented May 7, 2024

Fixes #9971.

@philderbeast philderbeast force-pushed the fix/list-configs-msg-9971 branch 2 times, most recently from 2c8ba7e to 369a7b7 Compare May 7, 2024 23:34
@philderbeast
Copy link
Collaborator Author

philderbeast commented May 8, 2024

@Mikolaj and @ffaf1 I saw the pre-release announcement for cabal-install-3.12.0.0. Is there still time to get this bug fix in to the release proper?

@ffaf1
Copy link
Collaborator

ffaf1 commented May 8, 2024

@ulysses4ever is the release manager for 3.12.1.0, which will be cabal-install proper, he will know for sure!

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This has the potential of introducing new bugs, though, and it didn't get into the (first and last) pre-release. This is a fix for a long standing bug, not a regression, right?

@philderbeast
Copy link
Collaborator Author

This was for a situation we did not have a test for and missed at review. It is a message formatting boo-boo introduced by #9578 so its scope is limited to the display of a message.

@ulysses4ever
Copy link
Collaborator

For 3.12.1.0 — I'd hope so. For the prerelease — I doubt it, but @Mikolaj is managing the prerelease, I think, so he's the right person to ask.

@Mikolaj
Copy link
Member

Mikolaj commented May 8, 2024

OK, in that case, let's get this merged soon.

The prerelease has been shipped already, BTW. Just announced. :)

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks! Let's apply the labels soon!

@ulysses4ever
Copy link
Collaborator

@philderbeast do you want to apply the merge label?

@philderbeast
Copy link
Collaborator Author

Label merge+no rebase is necessary when the pull request is from an organisation.

@Mikolaj
Copy link
Member

Mikolaj commented May 14, 2024

@philderbeast: would you mind also rebasing manually so that the commit history is less non-linear? Thank you!

- Use real-life example from Cabal project in doctest
@philderbeast philderbeast force-pushed the fix/list-configs-msg-9971 branch from b0c0c77 to 325ff22 Compare May 14, 2024 13:51
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label May 16, 2024
@Mikolaj
Copy link
Member

Mikolaj commented May 17, 2024

Let me restart https://github.com/haskell/cabal/actions/runs/9080567805/job/25091173936?pr=9985. It may or may not be transient.

@mergify mergify bot merged commit 0cd512a into haskell:master May 17, 2024
50 checks passed
@geekosaur
Copy link
Collaborator

@mergify backport 3.12

Copy link
Contributor

mergify bot commented Jun 7, 2024

backport 3.12

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge+no rebase type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomprehensible "imported by" noise when package doesn't exist
5 participants