Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cabal and Cabal-syntax to allow 3.14 #319

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Sep 3, 2024

I have tested the change by running cabal build all && cabal test all with the following cabal.project.local:

packages: /path-to-cabal-repo/Cabal
packages: /path-to-cabal-repo/Cabal-syntax
constraints: Cabal==3.14.*
constraints: Cabal-syntax==3.14.*

where /path-to-cabal-repo is my local checkout of cabal 3.14

I have tested the change by running `cabal build all && cabal test all`
with the following cabal.project.local:

    packages: /path-to-cabal-repo/Cabal
    packages: /path-to-cabal-repo/Cabal-syntax
    constraints: Cabal==3.14.*
    constraints: Cabal-syntax==3.14.*

where /path-to-cabal-repo is my local checkout of cabal 3.14
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any objections to merging this, anybody?

@Mikolaj
Copy link
Member

Mikolaj commented Sep 4, 2024

Merging. @fgaz: thanks a lot!

@Mikolaj Mikolaj merged commit 58c0dfa into haskell:master Sep 4, 2024
31 checks passed
@fgaz fgaz deleted the cabal-3.14 branch September 4, 2024 12:14
@fgaz
Copy link
Member Author

fgaz commented Sep 4, 2024

Now we need this on hackage. Looking at the diff between master and the last version, we just need a revision

hackage-security/v0.6.2.6...master

@Mikolaj
Copy link
Member

Mikolaj commented Sep 4, 2024

Oh, well spotted. Any objections to revising? If not, and if nobody does, I will soon.

@andreasabel: I remember you have a bespoke system for noting down the revision in the actual cabal files. Shall I try to emulate this while I revise or just leave it to you?

@Mikolaj
Copy link
Member

Mikolaj commented Sep 5, 2024

For now, I've just made the revision: https://hackage.haskell.org/package/hackage-security-0.6.2.6/revisions/

@andreasabel
Copy link
Member

I guess x-revision: 3 in hackage-security.cabal is now outdated: https://github.com/haskell/hackage-security/pull/319/files#diff-e4f51efc4a32ec2324f64ef4e50bfbd56a48f987f31234374a908827aa4a8851L4

Should probably be bumped to 4 (or deleted if you do not want to maintain this field).

@andreasabel andreasabel added the re: dependencies Concerning bounds of dependencies (Haskell ecosystem) label Sep 7, 2024
@Mikolaj
Copy link
Member

Mikolaj commented Sep 7, 2024

Oh, so it's so simple. Fixed (updated). Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re: dependencies Concerning bounds of dependencies (Haskell ecosystem)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants