Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Add unix-time constraint to cabal file #1306

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

alanz
Copy link
Collaborator

@alanz alanz commented Jun 21, 2019

This makes sure PR #1304 is complete, constraining the cabal build as
well, for Windows 7

This makes sure PR haskell#1304 is complete, constraining the cabal build as
well, for Windows 7
@jneira
Copy link
Member

jneira commented Jun 21, 2019

Maybe it would be not needed: see #1304 (comment)
I am currently tested a cabal new-build on master (without bounds for unix-time) and:

Resolving dependencies...
Build profile: -w ghc-8.6.5 -O1
In order, the following will be built (use -v for more details):
 - Cabal-2.4.1.0 (lib) (requires build)
....
- unix-time-0.4.7 (lib:unix-time) (requires download & build)
....

But maybe it is safer to add it in case an upper bound is added upstream (although it would be rare)

@alanz alanz mentioned this pull request Jun 21, 2019
@alanz
Copy link
Collaborator Author

alanz commented Jun 21, 2019

Appveyor failure on one build unrelated to this. Going to merge

@alanz alanz merged commit 70fb79e into haskell:master Jun 21, 2019
@alanz alanz added this to the 2019-06 milestone Jul 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants