-
Notifications
You must be signed in to change notification settings - Fork 210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it has been a matter of time before this happens.
This is necessary, because when we upgrade cabal-helper, and transivitely cabal-plan to version 0.5.0.0 in haskell#1126, the minimum cabal-version is 2.2. However, each stack snapshot ships with its own version of cabal-install that can not be changed. The latest lts for ghc-8.2.2 is 11.18, which ships with a cabal-install version of 2.0.0.1, which is too old for cabal-plan 0.5.0.0. However, in general, there is nothing that forces us to drop support for GHC 8.2.2. Overriding the compiler version should be possible, e.g. taking the snapshort 14.8 and overriding the GHC version, but this requires us to do manual constraint solving. Could be done if needed.
259f0e5
to
339dce3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we’re dropping the snapshot then we might as well drop building with 8.2 entirely, as it won’t get installed in the install script. From what I remember as well there’s a couple of semi group related CPP parts we have for 8.2 which would be nice to drop
I assume that most users could use a ghc version greater than 8.2, but |
@jneira we will just have to put up with that, people using the older GHC can still use the last hie that supported it. And I think It has been a second class citizen for some time, running with older versions of things like hlint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.2.2
is cited a few times inside the test
folder. The cpp call MIN_VERSION_GLASGOW_HASKELL(8,2,2,0)
should be upgraded?
2149e51
to
a5b44db
Compare
One more review, now deletes all legacy code that was necessary for compatibility with GHC 8.2.2. Including tests, dependencies in .cabal files and CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor nitpicks of left over comments
66c86d4
to
7fb438c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files still containing 8.2.2
:
test/wrapper/HieWrapper.hs
test/unit/GhcModPluginSpec.hs
HieWrapper tests are simple tests that check that the correct ghc version is discovered, no change necessary. |
7fb438c
to
8f66e28
Compare
I am happy for this to land when CI passes |
This is necessary, because when we upgrade cabal-helper,
and transivitely cabal-plan to version 0.5.0.0 in #1126,
the minimum cabal-version is 2.2.
However, each stack snapshot ships with its own version
of cabal-install that can not be changed.
The latest lts for ghc-8.2.2 is 11.18, which ships with
a cabal-install version of 2.0.0.1, which is too old
for cabal-plan 0.5.0.0.
However, in general, there is nothing that forces us to
drop support for GHC 8.2.2. Overriding the compiler version
should be possible, e.g. taking the snapshort 14.8 and
overriding the GHC version, but this requires us
to do manual constraint solving. Could be done if needed.
closes #1425