Strip RTS flags, since we cant honor them #1736

fendor · 2020-04-13T14:00:59Z

Issue that caused it: haskell#1725 the problem is that we cant honour the `+RTS` flags, since these need to be known when GHC is started. However, HIE is the compiler and is started before we load any component. Therefore, these options for the different component are unusable and we strip them here to avoid a bug. This commit is inspired by haskell/hie-bios#102

jneira · 2020-04-13T15:30:51Z

The ghc user guide says:

No -RTS option is required if the runtime-system options extend to the end of the command line, as in this example:

% hls -ltr /usr/etc +RTS -A5m

If you absolutely positively want all the rest of the options in a command line to go to the program (and not the RTS), use a --RTS.

would the code have to handle those cases?

fendor · 2020-04-13T15:33:36Z

Nope, this only for loading a specific component. With cabal-helper, we obtain the ghc-options flags and we need to filter them, since we cant use them in an existing GHC session.

fendor force-pushed the strip-rts branch from 42192b5 to 16d2fda Compare April 13, 2020 14:04

fendor requested review from jneira and lukel97 April 13, 2020 14:21

fendor merged commit e61670f into haskell:master Apr 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Strip RTS flags, since we cant honor them #1736

Strip RTS flags, since we cant honor them #1736

fendor commented Apr 13, 2020

jneira commented Apr 13, 2020 •

edited

Loading

fendor commented Apr 13, 2020

Strip RTS flags, since we cant honor them #1736

Strip RTS flags, since we cant honor them #1736

Conversation

fendor commented Apr 13, 2020

jneira commented Apr 13, 2020 • edited Loading

fendor commented Apr 13, 2020

jneira commented Apr 13, 2020 •

edited

Loading