Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't suggest adding extensions which have been explicitly disabled #606

Closed
expipiplus1 opened this issue Nov 18, 2020 · 1 comment · Fixed by #666
Closed

Don't suggest adding extensions which have been explicitly disabled #606

expipiplus1 opened this issue Nov 18, 2020 · 1 comment · Fixed by #666
Labels
component: ghcide type: enhancement New feature or request

Comments

@expipiplus1
Copy link
Contributor

In this file I have set -XNoDataKinds but HLS suggests adding it!

image

Furthermore, if I follow the suggestion it does add DataKinds to the extensions, but to no effect because NoDataKinds hasn't been removed. The suggestion sticks around too.

image

Probably best not to suggest things which are disabled or have already been enabled (and aren't taking affect for whatever reason)
@berberman berberman mentioned this issue Dec 12, 2020
Merged
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Dec 14, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not suggest explicitly disabled pragmas berberman/haskell-language-server
2 participants
@jneira @expipiplus1