Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create specific project file for ghc-8.10. #106

Merged
merged 1 commit into from
May 11, 2020
Merged

Create specific project file for ghc-8.10. #106

merged 1 commit into from
May 11, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented May 11, 2020 •
edited
Loading

  • It let us isolate temporary config tweaks in its own config file like allow-newer and turning off docs
  • The install.hs script will pick it auto
  • But you have to remember use it wen building using directly cabal

@jneira
Create specific project file for ghc-8.10.
f37babd 
It let us isolate temporary config tweaks in its own config file
like `allow-newer` and turning off docs
@jneira jneira requested a review from lukel97 May 11, 2020 12:34
@fendor
Copy link
Collaborator

fendor commented May 11, 2020

Is cabal.project-8.10.1 the correct name for such a file? Shouldnt it be named like the local file, cabal.project.8.10.1? I think I remember that someone said that cabal picks it up automatically if it is named that way, or did I imagine that?

@jneira
Copy link
Member Author

jneira commented May 11, 2020

I think I remember that someone said that cabal picks it up automatically if it is named that way, or did I imagine that?

It does not afaik, but it would be really really great (i am afraid it is too beauty to be true 😄 )

Not sure why did we choose - tbh.

@fendor
Copy link
Collaborator

fendor commented May 11, 2020

It does not afaik, but it would be really really great (i am afraid it is too beauty to be true 😄 )

True, that doesnt work

lukel97
lukel97 approved these changes May 11, 2020
View reviewed changes
Copy link
Collaborator

@lukel97 lukel97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, writing it down here that the flag to use is cabal build --project-file
And as long as we remember to remove this at some point

@jneira jneira merged commit 54cd823 into haskell:master May 11, 2020
@jneira jneira deleted the project-8.10.1 branch May 13, 2020 19:08
pepeiborra pushed a commit that referenced this pull request Dec 27, 2020
@jacg @cocreature
Add --version CLI option (#106)
c24ef1c 
* Add --version CLI option

* Extract ghcide version from cabal

* Extract precise GHC version from cabal preprocessor macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@lukel97 lukel97 lukel97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jneira @fendor @lukel97