Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghcide: Implements a CodeAction to disambiguate ambiguous symbols #1264

Merged
merged 52 commits into from
Jan 31, 2021
Merged

ghcide: Implements a CodeAction to disambiguate ambiguous symbols #1264

merged 52 commits into from
Jan 31, 2021

Commits on Jan 26, 2021

  1. wip

    @konn
    konn committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    b35aa37 View commit details
    Browse the repository at this point in the history

  2. Draft completed

    @konn
    konn committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    cbcb0f0 View commit details
    Browse the repository at this point in the history

  3. Removes Unuseds

    @konn
    konn committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    a068257 View commit details
    Browse the repository at this point in the history

  4. Redundant extension

    @konn
    konn committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    e506ddf View commit details
    Browse the repository at this point in the history

  5. linting

    @konn
    konn committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    a995c5e View commit details
    Browse the repository at this point in the history

  6. Makes HLint happy

    @konn
    konn committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    169db8f View commit details
    Browse the repository at this point in the history

  7. tweak for transfer annotation logic (not working)

    @konn
    konn committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    4e92ee9 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Initial implementation done

    @konn
    konn committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    72477dd View commit details
    Browse the repository at this point in the history

  2. Import list reorder

    @konn
    konn committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    65724fa View commit details
    Browse the repository at this point in the history

  3. Remove redundant fmt

    @konn
    konn committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    4ed8abc View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Merge branch 'master' into hide-import

    @konn
    konn committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    80aafa7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into hide-import

    @konn
    konn authored Jan 28, 2021
    Configuration menu
    Copy the full SHA
    197a8a3 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Merge branch 'master' into hide-import

    @konn
    konn committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    d99f84c View commit details
    Browse the repository at this point in the history

  2. lint

    @konn
    konn committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    30f2f16 View commit details
    Browse the repository at this point in the history

  3. Missing import

    @konn
    konn committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    9e656c5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into hide-import

    @konn
    konn authored Jan 29, 2021
    Configuration menu
    Copy the full SHA
    3e68f24 View commit details
    Browse the repository at this point in the history

  5. Excludes false-positive qualified imports

    @konn
    konn committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    d19b4fb View commit details
    Browse the repository at this point in the history

  6. A first test (not enough though)

    @konn
    konn committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    eb3cd11 View commit details
    Browse the repository at this point in the history

  7. fmt.sh

    @konn
    konn committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    0239aa0 View commit details
    Browse the repository at this point in the history

  8. Some more test cases

    @konn
    konn committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    a6ddab2 View commit details
    Browse the repository at this point in the history

  9. More test cases

    @konn
    konn committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    4816c84 View commit details
    Browse the repository at this point in the history

  10. Ah! CRLF have bitten me!

    @konn
    konn committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    3b6c048 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2021

  1. Merge branch 'master' into hide-import

    @konn
    konn authored Jan 30, 2021
    Configuration menu
    Copy the full SHA
    ed73a63 View commit details
    Browse the repository at this point in the history

  2. Tentative workaround for #1274

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    dff4d03 View commit details
    Browse the repository at this point in the history

  3. Wait much to ensure rewrite suggestion to be collected

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    0696e5a View commit details
    Browse the repository at this point in the history

  4. Tests for type suggestion

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    c2907dd View commit details
    Browse the repository at this point in the history

  5. Slightly more wait

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    41d6c75 View commit details
    Browse the repository at this point in the history

  6. A little smarter waiting strartegy for actions

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    223808b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into hide-import

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    abbebf5 View commit details
    Browse the repository at this point in the history

  8. Import list slim up

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    0721ef9 View commit details
    Browse the repository at this point in the history

  9. Adjusted to the master

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    7487446 View commit details
    Browse the repository at this point in the history

  10. Update ghcide/src/Development/IDE/Plugin/CodeAction.hs 

    Co-authored-by: Pepe Iborra <pepeiborra@me.com>
    @konn @pepeiborra
    konn and pepeiborra authored Jan 30, 2021
    Configuration menu
    Copy the full SHA
    b5b7f03 View commit details
    Browse the repository at this point in the history

  11. Rewrote using expectDiagnostics

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    d4075dc View commit details
    Browse the repository at this point in the history

  12. Case for Prelude.++

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    130afec View commit details
    Browse the repository at this point in the history

  13. Corrects test name

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    a3486ac View commit details
    Browse the repository at this point in the history

  14. Renames rawIEWrapName to unqualIEWrapName, and moved to the appro… 

    …priate module
    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    c252aca View commit details
    Browse the repository at this point in the history

  15. Rewrote qualifying strategy with Rewrite

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    f6594fd View commit details
    Browse the repository at this point in the history

  16. Use exactprint also for hideImplicitPreludeSymbol

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    e694694 View commit details
    Browse the repository at this point in the history

  17. Unify exact actions and suggestImportDisambiguation

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    0550b6f View commit details
    Browse the repository at this point in the history

  18. Moves a comment to the right place

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    bf99f31 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'master' into hide-import

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    1a736ad View commit details
    Browse the repository at this point in the history

  20. Won't panic on errornous input, let HLS keep going

    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    d96d612 View commit details
    Browse the repository at this point in the history

  21. No, each errornous rewrite must not be dropped seprately, but discard… 

    …ed as a whole
    @konn
    konn committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    10cc815 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2021

  1. Update ghcide/src/Development/IDE/Spans/Common.hs 

    Co-authored-by: Potato Hatsue <berberman@yandex.com>
    @konn @berberman
    konn and berberman authored Jan 31, 2021
    Configuration menu
    Copy the full SHA
    82345d1 View commit details
    Browse the repository at this point in the history

  2. ieNames

    @konn
    konn committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    191df1b View commit details
    Browse the repository at this point in the history

  3. Makes Splice plugin compiles

    @konn
    konn committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    3b2b4e8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into hide-import

    @konn
    konn committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    ced501f View commit details
    Browse the repository at this point in the history

  5. Stop using nfp

    @konn
    konn committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    d75b51e View commit details
    Browse the repository at this point in the history

  6. Since there is global setEntryDPT dp00, we don't add offset here

    @konn
    konn committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    13b9f2c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into hide-import

    @konn
    konn committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    54f5a49 View commit details
    Browse the repository at this point in the history

  8. Removes redundant (why warned here?)

    @konn
    konn committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    4aae21a View commit details
    Browse the repository at this point in the history

  9. Made hideImplicitPreludeSymbol total

    @konn
    konn committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    a45667b View commit details
    Browse the repository at this point in the history