Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default main for ghcide #1338

Merged
merged 6 commits into from
Feb 12, 2021
Merged

Default main for ghcide #1338

merged 6 commits into from
Feb 12, 2021

Conversation

pepeiborra
Copy link
Collaborator

Fixes #1336

@wz1000
Copy link
Collaborator

wz1000 commented Feb 9, 2021

I thought the goal was sharing the main function between HLS and ghcide?

wz1000
wz1000 reviewed Feb 9, 2021
View reviewed changes
ghcide/exe/Main.hs Outdated Show resolved Hide resolved
@pepeiborra
Copy link
Collaborator Author

I thought the goal was sharing the main function between HLS and ghcide?

That's the stretch goal. The two seem to have diverged, so I think it's better to go step by step and do it in separate PRs

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Feb 9, 2021
@pepeiborra pepeiborra force-pushed the default-main branch 2 times, most recently from 4cd3b1f to 93b5542 Compare February 9, 2021 20:08
@pepeiborra
Copy link
Collaborator Author

@wz1000 I have implemented the stretch goal too.

@pepeiborra pepeiborra force-pushed the default-main branch 2 times, most recently from 6531d07 to f2ee6ea Compare February 9, 2021 20:16
wz1000
wz1000 reviewed Feb 9, 2021
View reviewed changes
src/Ide/Main.hs Show resolved Hide resolved
@pepeiborra
Copy link
Collaborator Author

A ghc 8.10.4 install failed due to a ghcup segfault:

  Attempting to install ghc 8.10.4 using ghcup
26
  /opt/hostedtoolcache/ghcup/0.1.12/x64/ghcup install ghc 8.10.4
27
  ghcup: internal error: Itimer: read(timerfd) failed with Bad file descriptor and returned -1
28
      (GHC version 8.8.4 for x86_64_alpine_linux)
29
      Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug

@pepeiborra pepeiborra force-pushed the default-main branch 7 times, most recently from 6401a22 to fc21b2e Compare February 10, 2021 23:27
@konn
Copy link
Collaborator

konn commented Feb 11, 2021

Gresat! So, once this PR have landed, we can break down our monolithic func-test into per-plugin ones, right?

@pepeiborra
Copy link
Collaborator Author

pepeiborra commented Feb 11, 2021 •
edited
Loading

@jneira the 8.10.4 func-test suite is failing

Gresat! So, once this PR have landed, we can break down our monolithic func-test into per-plugin ones, right?

Yeah, this PR will make it simpler to run ghcide with a custom set of HLS plugins for use in tests

@pepeiborra
Development.IDE.Main
bdeb8b0
@pepeiborra
Reuse Development.IDE.Main in HLS
21cc46a
@pepeiborra
Bump ghcide version number and HLS minbound
7019793 
Seems like now is the best moment to do it and avoid later accidents
@pepeiborra
(unrelated) disable cradle experiments in ghcide test suite
b385c01 
```
  benchmark experiments
674
    hover:                                                                                                OK (30.50s)
675
    hover after edit:                                                                                     OK (65.67s)
676
    getDefinition:                                                                                        OK (12.24s)
677
    getDefinition after edit:                                                                             OK (62.37s)
678
    documentSymbols:                                                                                      OK (13.95s)
679
    documentSymbols after edit:                                                                           OK (16.87s)
680
    completions:                                                                                          OK (13.64s)
681
    completions after edit:                                                                               OK (66.82s)
682
    code actions:                                                                                         OK (13.80s)
683
    code actions after edit:                                                                              OK (58.70s)
684
    code actions after cradle edit:                                                                       OK (1244.46s)
685
    hover after cradle edit:
    OK (1230.61s)
    ```
@pepeiborra
Fix config
e87fb93
@jneira
Copy link
Member

jneira commented Feb 11, 2021

mmm it worked in master and previous pr's, no?
I will take a look
do you want to test 8.10.3 again?

@pepeiborra
Copy link
Collaborator Author

mmm it worked in master and previous pr's, no?
I will take a look
do you want to test 8.10.3 again?

Never mind, it was an issue with the PR. The problem now is that the MacOs builds are failing across all my PRs with a weird error:

image

image

@mergify mergify bot merged commit a49f366 into master Feb 12, 2021
@jneira jneira mentioned this pull request Feb 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wz1000 wz1000 wz1000 approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extract defaultMain for ghcide
4 participants
@pepeiborra @wz1000 @konn @jneira