Index files on first open #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ailrun
reviewed
Feb 12, 2021
|
Are there any downsides to not reindexing FOIs? EDIT: ignore me, I see that we already don't reindex FOIs, this change will reindex them on first open |
pepeiborra
approved these changes
Feb 12, 2021
|
The most straightforward test I can think of will only show observable differences when #1357 lands. I'll add a test case after that. BTW we already do index FOIs on save. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to index files on every change as this is needlessly expensive, but it is good to index them on first open so that information from the file is available in the next ghcide session.