-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use implicit-hie cradle #138
Conversation
adc7ce0
to
caf0a0d
Compare
|
caf0a0d
to
9fd8151
Compare
Followup to this would be preferred cabal or stack config. I thought about doing this via Is it easy to make cabal-helper follow this config? I have not yet looked into it. |
cabal-helper can implement this behaviour easily. Just filter for the project context, if there is none report an error, otherwise use the context |
In light of yet another reddit post by someone confused by It's better then nothingI would like to push for this to be merged, it does not always generate the exact right config, but it works for ever config a beginner would use. When it fails, the There are better solutions in the pipeline, but that should not stop us from improving user experience now. Let's not let perfect be the enemy of good. |
Agree, i thought a more complete version would be ready sooner. |
source-repository-package | ||
type: git | ||
location: https://github.com/mpickering/hie-bios | ||
tag: a852cffb0deb306cd1e1fe02aa50d50c77aeb15d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneeded, afaict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed for haskell/hie-bios@a852cff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Please rebase, maybe some words in the README how your tool can be used to generate a hie.yaml
config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the wrapper needs to be modified, otherwise it will continue to use cabal-helper.
The change should be of the same size.
I'll rebase, when I get a chance hopefully tomorrow, very busy. |
@fendor I'm in the process of rebasing, but hie-bios has changed, how soon before the next hie-bios release. Unless we want hls to depend on an out of date, but still not published hie-bio commit we need to wait until hls is using a newer hie-bios. |
@Avi-D-coder I want to hopefully do a release this week, but there are three pending PRs that need to be reviewed and merged. So, unfortunately, no promises. |
@fendor @Avi-D-coder what is holding this up? I think it is important we get it in. |
@alanz A hie-bios release that includes: haskell/hie-bios@a852cff |
New version of hie-bios needs to be released, ghcide & hls need to use it, and then I need to find time to rebase and fix the wrapper. |
Ok, so it is waiting, rather than abandoned. Thanks. |
Rebased at #186 |
Companion to #110