Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat all files #1439

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Reformat all files #1439

merged 2 commits into from
Feb 25, 2021

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented Feb 24, 2021

This is a successor of #1384.

However, some CPP modules do not work with any formatters (including stylish-haskell, ormolu, brittany), so I format them by manually removing and then re-adding CPP parts.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! it seems the code base was following the formatter rules, not much locs

@Ailrun
Copy link
Member Author

Ailrun commented Feb 24, 2021

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2021

Command rebase: success

Branch has been successfully rebased

@Ailrun Ailrun merged commit 679f1d0 into haskell:master Feb 25, 2021
@isovector
Copy link
Collaborator

Can I opt out of changes like this for tactics in the future? Splitting up imports over multiple lines severely breaks my workflow.

@Ailrun
Copy link
Member Author

Ailrun commented Feb 26, 2021

@isovector May I ask what kinds of workflow, if you don't mind? As we now have a pre-commit hook for formatting and will add CI checker, format will be enforced (except for hie-compat, with the justification of "we want to leave the code as close to original GHC code as possible).

Maybe #693 is a better place to discuss about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants